[
https://issues.apache.org/jira/browse/HBASE-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647015#comment-14647015
]
Andrew Purtell commented on HBASE-14154:
----------------------------------------
Thanks [~ashish singhi].
When getting ready to commit this I did find one nit I missed on the first skim.
In HColumnDescriptor.java, this should return a short integer don't you think?
Currently it's a string and that is not symmetric with
{{setDFSReplication(short)}}. Instead of returning null if not set, return 0?
replication=0 makes no sense, that's a reasonable indication of 'not set'.
{code}
+ /** Return the replication factor for the family, or null if not set */
+ public String getDFSReplication() {
+ return getValue(DFS_REPLICATION);
+ }
{code}
If you agree, no need to make another set of patches, I can make that
modification at commit time and fix up the callers.
> DFS Replication should be configurable at column family level
> -------------------------------------------------------------
>
> Key: HBASE-14154
> URL: https://issues.apache.org/jira/browse/HBASE-14154
> Project: HBase
> Issue Type: New Feature
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.3.0
>
> Attachments: HBASE-14154-0.98.patch, HBASE-14154-branch-1.patch,
> HBASE-14154.patch
>
>
> There are cases where a user wants to have a control on the number of hfile
> copies he/she can have in the cluster.
> For eg: For a test table user would like to have only one copy instead of
> three(default).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
