[
https://issues.apache.org/jira/browse/HBASE-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648805#comment-14648805
]
Ashish Singhi commented on HBASE-14154:
---------------------------------------
Regarding the patch, some minor nits:
May be we can rename {{DFS_REPLICATION_DEFAULT}} to {{DEFAULT_DFS_REPLICATION}}
like we have for other default variables in the class.
{code}
return rf == null ? 0 : Short.valueOf(rf);
{code}
Instead of 0, we can use default variable same in java doc for the get api.
In FSUtils.java
{code}
short replication =
Short.parseShort(conf.get(HColumnDescriptor.DFS_REPLICATION, "0"));
{code}
Here we use {{DEFAULT_DFS_REPLICATION}} instead of 0 and update the java doc.
I can redo a patch myself but will wait for your response on the above comment
of mine.
Thanks.
> DFS Replication should be configurable at column family level
> -------------------------------------------------------------
>
> Key: HBASE-14154
> URL: https://issues.apache.org/jira/browse/HBASE-14154
> Project: HBase
> Issue Type: New Feature
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Priority: Minor
> Fix For: 2.0.0, 0.98.14, 1.3.0
>
> Attachments: HBASE-14154-0.98-v1.patch, HBASE-14154-0.98.patch,
> HBASE-14154-branch-1-v1.patch, HBASE-14154-branch-1.patch,
> HBASE-14154-v1.patch, HBASE-14154-v2.patch, HBASE-14154.patch
>
>
> There are cases where a user wants to have a control on the number of hfile
> copies he/she can have in the cluster.
> For eg: For a test table user would like to have only one copy instead of
> three(default).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
