[ 
https://issues.apache.org/jira/browse/HBASE-14154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649544#comment-14649544
 ] 

Ashish Singhi commented on HBASE-14154:
---------------------------------------

[[email protected]], what about the this comment. Do you think we need 
to address that nit ?
{quote}
bq. Another minor nit: I think there should be a check in setDFSReplication on 
whether the passed value is valid.
Is It really required ? Because we are already calling 
HMaster#sanityCheckTableDescriptor for both create and modify table calls, 
which will internally check this and I have not seen any setter validating for 
the passed values except HColumnDescriptor#setVersions, which is also being 
validated in HMaster#sanityCheckTableDescriptor.
{quote}

> DFS Replication should be configurable at column family level
> -------------------------------------------------------------
>
>                 Key: HBASE-14154
>                 URL: https://issues.apache.org/jira/browse/HBASE-14154
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.14, 1.3.0
>
>         Attachments: HBASE-14154-0.98-v1.patch, HBASE-14154-0.98.patch, 
> HBASE-14154-branch-1-v1.patch, HBASE-14154-branch-1.patch, 
> HBASE-14154-v1.patch, HBASE-14154-v2.patch, HBASE-14154.patch
>
>
> There are cases where a user wants to have a control on the number of hfile 
> copies he/she can have in the cluster.
> For eg: For a test table user would like to have only one copy instead of 
> three(default).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to