[ 
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682138#comment-14682138
 ] 

Hadoop QA commented on HBASE-14203:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12749858/HBASE-14203_v2.patch
  against master branch at commit 7d4de20cafd6b765bd5f33df72fc0e630d1731f7.
  ATTACHMENT ID: 12749858

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated 
1861 checkstyle errors (more than the master's current 1858 errors).

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush
                  org.apache.hadoop.hbase.client.TestSnapshotMetadata
                  
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRS
                  
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan1
                  org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
                  org.apache.hadoop.hbase.client.TestMetaWithReplicas
                  
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels
                  
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
                  org.apache.hadoop.hbase.client.TestFromClientSide3
                  org.apache.hadoop.hbase.mapreduce.TestHashTable
                  
org.apache.hadoop.hbase.replication.TestReplicationKillMasterRSCompressed
                  org.apache.hadoop.hbase.client.TestCheckAndMutate
                  org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
                  org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
                  org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster
                  org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss
                  org.apache.hadoop.hbase.util.TestHBaseFsck
                  org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient
                  org.apache.hadoop.hbase.mapreduce.TestImportTSVWithTTLs
                  org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence
                  org.apache.hadoop.hbase.replication.TestReplicationWithTags
                  org.apache.hadoop.hbase.mapreduce.TestCellCounter
                  org.apache.hadoop.hbase.security.access.TestNamespaceCommands
                  org.apache.hadoop.hbase.master.TestMasterShutdown
                  org.apache.hadoop.hbase.util.TestRegionSplitter
                  org.apache.hadoop.hbase.master.TestRestartCluster
                  
org.apache.hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
                  org.apache.hadoop.hbase.mapreduce.TestCopyTable
                  org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
                  org.apache.hadoop.hbase.snapshot.TestMobSecureExportSnapshot
                  
org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap
                  
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.mob.compactions.TestMobCompactor
                  org.apache.hadoop.hbase.client.TestPutWithDelete
                  org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
                  org.apache.hadoop.hbase.quotas.TestQuotaTableUtil
                  org.apache.hadoop.hbase.util.TestMergeTable
                  org.apache.hadoop.hbase.mob.mapreduce.TestMobSweeper
                  org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
                  org.apache.hadoop.hbase.security.access.TestAccessController
                  org.apache.hadoop.hbase.mob.TestDefaultMobStoreFlusher
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole
                  org.apache.hadoop.hbase.security.access.TestAccessController2
                  org.apache.hadoop.hbase.replication.TestReplicationSmallTests
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan2
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded
                  org.apache.hadoop.hbase.mob.mapreduce.TestMobSweepReducer
                  org.apache.hadoop.hbase.mapreduce.TestRowCounter
                  
org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
                  
org.apache.hadoop.hbase.client.replication.TestReplicationAdminWithClusters
                  org.apache.hadoop.hbase.util.TestHBaseFsckEncryption
                  org.apache.hadoop.hbase.client.TestHCM
                  org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential
                  org.apache.hadoop.hbase.mapreduce.TestImportExport
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase
                  org.apache.hadoop.hbase.snapshot.TestMobExportSnapshot
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2
                  org.apache.hadoop.hbase.TestNamespace
                  org.apache.hadoop.hbase.replication.TestReplicationEndpoint
                  
org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk
                  
org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient
                  
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
                  org.apache.hadoop.hbase.client.TestClientTimeouts
                  org.apache.hadoop.hbase.mapreduce.TestSyncTable
                  
org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient
                  org.apache.hadoop.hbase.TestInfoServers
                  org.apache.hadoop.hbase.TestRegionRebalancing
                  org.apache.hadoop.hbase.mapreduce.TestTableInputFormat
                  
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.client.TestMobSnapshotFromClient
                  
org.apache.hadoop.hbase.replication.TestReplicationChangingPeerRegionservers
                  org.apache.hadoop.hbase.quotas.TestQuotaThrottle
                  org.apache.hadoop.hbase.quotas.TestQuotaAdmin
                  org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel
                  
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFilesSplitRecovery
                  org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
                  
org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas
                  
org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence
                  org.apache.hadoop.hbase.master.TestRegionPlacement
                  org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
                  org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool
                  org.apache.hadoop.hbase.TestIOFencing
                  org.apache.hadoop.hbase.snapshot.TestExportSnapshot
                  
org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
                  org.apache.hadoop.hbase.client.TestAdmin1
                  org.apache.hadoop.hbase.client.TestFromClientSide
                  org.apache.hadoop.hbase.replication.TestReplicationKillSlaveRS
                  
org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions
                  org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
                  
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
                  org.apache.hadoop.hbase.mapreduce.TestMultiTableInputFormat
                  
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithOperationAttributes

     {color:red}-1 core zombie tests{color}.  There are 3 zombie test(s):       
at 
org.apache.hadoop.hbase.regionserver.TestRegionReplicas.testFlushAndCompactionsInPrimary(TestRegionReplicas.java:411)
        at 
org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover.testLotsOfRegionReplicas(TestRegionReplicaFailover.java:357)
        at 
org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush.testLogReplayWithDistributedLogSplit(TestPerColumnFamilyFlush.java:430)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15047//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15047//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15047//artifact/patchprocess/checkstyle-aggregate.html

                Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15047//console

This message is automatically generated.

> remove duplicate code getTableDescriptor in HTable
> --------------------------------------------------
>
>                 Key: HBASE-14203
>                 URL: https://issues.apache.org/jira/browse/HBASE-14203
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Heng Chen
>            Priority: Trivial
>         Attachments: HBASE-14203.patch, HBASE-14203_v2.patch
>
>
> As TODO in comment said, 
> {{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}. 
> remove the duplicate code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to