[jira] [Commented] (HBASE-14203) remove duplicate code getTableDescriptor in HTable

[Enis Soztutar (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696905#comment-14696905
 ] 

Enis Soztutar commented on HBASE-14203:
---------------------------------------

Thanks [~chenheng], patch looks good. Two more suggestions: 
- lets make this package-protected. We do not want to expose it to users: 
{code}
+  public static HTableDescriptor getTableDescriptor(final TableName tableName,
{code}
 - It is not you, but we had recently changed the meta table descriptor so that 
it is not hard coded anymore in HBaseAdmin. Let's also not return the hard 
coded one in HTable and be consistent with the HBaseAdmin one: 
{code}
+    if (tableName != null && tableName.equals(TableName.META_TABLE_NAME)) {
       return HTableDescriptor.META_TABLEDESC;
     }
{code}

> remove duplicate code getTableDescriptor in HTable
> --------------------------------------------------
>
>                 Key: HBASE-14203
>                 URL: https://issues.apache.org/jira/browse/HBASE-14203
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Heng Chen
>            Priority: Trivial
>         Attachments: HBASE-14203.patch, HBASE-14203_v2.patch, 
> HBASE-14203_v3.patch, HBASE-14203_v4.patch
>
>
> As TODO in comment said, 
> {{HTable.getTableDescriptor}} is same as {{HAdmin.getTableDescriptor}}. 
> remove the duplicate code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)