[
https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694858#comment-14694858
]
Anoop Sam John commented on HBASE-14144:
----------------------------------------
FirstOnRowBBFakeCell
Need to override getRowArray also as the super class returns empty byte[]. We
can use CellUtil clone API
FirstOnRowColBBFakeCell
Same way override getQualifierArray
{code}
Cell kvKey = KeyValueUtil.createFirstOnRow(row, 0, row.length,
1252 HConstants.EMPTY_BYTE_ARRAY, 0, 0, column, 0,
1253 column.length);
1254 return passesGeneralRowColBloomFilter(kvKey);
{code}
Here we are creating a KV by copy and later down in
checkGeneralBloomFilter(byte[] key, Cell kvKey, BloomFilter bloomFilter) we
again create
Cell rowBloomKey = CellUtil.createFirstOnRow(kvKey);
Can we avoid? Some sort of refactoring may be needed. Any chance to use
CellUtil instead of KeyValueUtil and avoid a copy?
We may have to change Hash function to work with BB also? Later in another jira
may be
FirstOnRowBBFakeCell -> Better we can name it as FirstOnRowFakeBBCell
> Bloomfilter path to work with Byte buffered cells
> -------------------------------------------------
>
> Key: HBASE-14144
> URL: https://issues.apache.org/jira/browse/HBASE-14144
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-14144.patch, HBASE-14144_1.patch,
> HBASE-14144_2.patch, HBASE-14144_3.patch
>
>
> This JIRA is to check if there will be a need to make the bloom filters to
> work with ByteBuffer cells. During POC this path created lot of duplicated
> code but considering other refactorings done in this path may lead to less
> duplication. This JIRA is a placeholder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
