[ 
https://issues.apache.org/jira/browse/HBASE-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712364#comment-14712364
 ] 

chunhui shen commented on HBASE-6617:
-------------------------------------

Take a quick look about the patch.
As my thought, we should keep the function of ReplicationSource unchanged which 
replicate the logs to one peer cluster. 
With the patch,  we will have many replication source objects if many wal group 
exits.  And I only found creating ReplicationSource when new wal group used, 
but no deleting. After a long running, as the creating and deleting of wal 
group,  ReplicationSource seems the trouble of server.

Thus, I suggest track multi logs for one replication source, rather than multi 
replication source for multi logs .
Correct me if something wrong.
Thanks

> ReplicationSourceManager should be able to track multiple WAL paths
> -------------------------------------------------------------------
>
>                 Key: HBASE-6617
>                 URL: https://issues.apache.org/jira/browse/HBASE-6617
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Ted Yu
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-6617.patch, HBASE-6617_v2.patch, 
> HBASE-6617_v3.patch
>
>
> Currently ReplicationSourceManager uses logRolled() to receive notification 
> about new HLog and remembers it in latestPath.
> When region server has multiple WAL support, we need to keep track of 
> multiple Path's in ReplicationSourceManager



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to