[
https://issues.apache.org/jira/browse/HBASE-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720317#comment-14720317
]
Hadoop QA commented on HBASE-14332:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12752994/HBASE-14332.patch
against master branch at commit cc1542828de93b8d54cc14497fd5937989ea1b6d.
ATTACHMENT ID: 12752994
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1853 checkstyle errors (more than the master's current 1849 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ TableState.State state =
this.assignmentManager.getTableStateManager().setTableStateIfInStates(
+ TableState.State state =
this.assignmentManager.getTableStateManager().setTableStateIfInStates(
+ setFailure("master-disable-table", new
TableNotEnabledException(tableName+" state is "+state.name()));
+ setFailure("master-enable-table", new
TableNotDisabledException(this.tableName+" state is "+state.name()));
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 8 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15316//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15316//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15316//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15316//console
This message is automatically generated.
> Show the table state when we encounter exception while disabling / enabling
> table
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14332
> URL: https://issues.apache.org/jira/browse/HBASE-14332
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Nick.han
> Assignee: Nick.han
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-14332.patch
>
>
> This patch is a advice for good user experience
> reason:
> When we disable a table and the table is not enabled,we receive a
> exception,but the exception is too brief,some time we want to know what
> state is the table in,so that we can know why the table can't be disable.For
> example,I once encountered a problem the table is neither disable nor enable
> when my region server crash down,if we give the table state,I will find the
> problem more quickly .
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
