[ 
https://issues.apache.org/jira/browse/HBASE-14332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14721573#comment-14721573
 ] 

Ted Yu commented on HBASE-14332:
--------------------------------

{code}
80         * @return null if successed or table state if failed
{code}
successed: typo
{code}
297           TableState.State state = tsm.getTableState(tableName);
298           //if 
(!tsm.getTableState(tableName).equals(TableState.State.ENABLED)) {
...
317           TableState.State state = tsm.getTableState(tableName);
318           //if 
(!tsm.getTableState(tableName).equals(TableState.State.DISABLED)) {
{code}
Remove commented out code above.

> Show the table state when we encounter exception while disabling / enabling 
> table
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-14332
>                 URL: https://issues.apache.org/jira/browse/HBASE-14332
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Nick.han
>            Assignee: Nick.han
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14332.patch, HBASE-14332_v2.patch
>
>
> This patch is a advice for good user experience
> reason:
> When we disable a table and the table is not enabled,we receive a 
> exception,but the exception is too brief,some time we  want to know what 
> state is the table in,so that we can know why the table can't be disable.For 
> example,I once encountered a problem the table is neither disable nor enable 
> when my region server crash down,if we give the table state,I will find the 
> problem more quickly .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to