[
https://issues.apache.org/jira/browse/HBASE-14051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744475#comment-14744475
]
Enis Soztutar commented on HBASE-14051:
---------------------------------------
Did you miss a negation ({{!}}) here:
{code}
+ public static boolean inconsistencyFound(HBaseFsck fsck) throws Exception {
+ List<ERROR_CODE> errs = fsck.getErrors().getErrorList();
+ return (errs == null || errs.isEmpty());
+ }
{code}
if errs is null or empty there is no inconsistency, no?
> Undo workarounds in IntegrationTestDDLMasterFailover for client double submit
> -----------------------------------------------------------------------------
>
> Key: HBASE-14051
> URL: https://issues.apache.org/jira/browse/HBASE-14051
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Reporter: Enis Soztutar
> Assignee: Sophia Feng
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14051.patch
>
>
> Now that nonce support for dealing with double-submits from client in
> HBASE-13415 is committed, we should undo the workarounds done in HBASE-13470
> for this part. We needed these workarounds for 1.1.1, but we should not do
> that anymore for proper testing for 1.2+.
> [~syuanjiang], [~fengs], [~mbertozzi] FYI.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)