[
https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14877468#comment-14877468
]
Hadoop QA commented on HBASE-14448:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12761322/HBASE-14448_v2.patch
against master branch at commit a7afc132e2db7ebbb571b43ae17161bff40b59c5.
ATTACHMENT ID: 12761322
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15643//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15643//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15643//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15643//console
This message is automatically generated.
> Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize
> wal group name
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-14448
> URL: https://issues.apache.org/jira/browse/HBASE-14448
> Project: HBase
> Issue Type: Improvement
> Reporter: Yu Li
> Assignee: Yu Li
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14448.patch, HBASE-14448_v2.patch
>
>
> Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which
> makes the logic ambiguous since a "provider" itself should provide logs.
> Suggest to directly instantiate FSHlog in RegionGroupingProvider.
> W.r.t wal group name, now in RegionGroupingProvider it's using sth like
> "<factoryId>-null-<randomUUID>" which is quite long and unnecessary. Suggest
> to directly use "<providerId>.<groupName>".
> For more details, please refer to the initial patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
