[ 
https://issues.apache.org/jira/browse/HBASE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14900728#comment-14900728
 ] 

Yu Li commented on HBASE-14448:
-------------------------------

Checking the UT failures, TestImportExport and TestProcessBasedCluster should 
be env-issue-caused intermittent failure, and TestFastFail expose a small 
regression issue caused by HBASE-14431 and attached an addendum there. All 
failures should be irrelative to the patch of this JIRA.

Thanks [~tedyu] for the careful review!

> Refine RegionGroupingProvider Phase-2: remove provider nesting and formalize 
> wal group name
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14448
>                 URL: https://issues.apache.org/jira/browse/HBASE-14448
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-14448.patch, HBASE-14448_v2.patch, 
> HBASE-14448_v3.patch
>
>
> Now we are nesting DefaultWALProvider inside RegionGroupingProvider, which 
> makes the logic ambiguous since a "provider" itself should provide logs. 
> Suggest to directly instantiate FSHlog in RegionGroupingProvider.
> W.r.t wal group name, now in RegionGroupingProvider it's using sth like 
> "<factoryId>\-null\-<randomUUID>" which is quite long and unnecessary. 
> Suggest to directly use "<providerId>.<groupName>".
> For more details, please refer to the initial patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to