[ 
https://issues.apache.org/jira/browse/HBASE-14473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905265#comment-14905265
 ] 

Mikhail Antonov commented on HBASE-14473:
-----------------------------------------

Thanks for explanation, looks good to me, +1.

This

bq. @return true if region locations got refreshed.

is inconsistent w/ what it actually returns, right? Should be "if  locations 
for some user tables got refreshed"?

I suppose 5 hardcoded thread in threadpool are just fine. Also seems this class 
missing audience annotation, do you want to add Private one?

> Compute region locality in parallel
> -----------------------------------
>
>                 Key: HBASE-14473
>                 URL: https://issues.apache.org/jira/browse/HBASE-14473
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer
>    Affects Versions: 1.2.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14473-v1.patch, HBASE-14473-v2.patch, 
> HBASE-14473.patch
>
>
> Right now on large clusters it's necessary to turn off the locality balance 
> cost as it takes too long to compute the region locality. This is because 
> it's computed when need in serial.
> We should compute this in parallel before it's needed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to