[ 
https://issues.apache.org/jira/browse/HBASE-14205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905737#comment-14905737
 ] 

Hadoop QA commented on HBASE-14205:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12762002/HBASE-14205.patch
  against master branch at commit 5e26ae043dde217aeda29d9b67e290728adade89.
  ATTACHMENT ID: 12762002

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 7 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15701//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15701//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15701//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15701//console

This message is automatically generated.

> RegionCoprocessorHost System.nanoTime() performance bottleneck
> --------------------------------------------------------------
>
>                 Key: HBASE-14205
>                 URL: https://issues.apache.org/jira/browse/HBASE-14205
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jan Van Besien
>            Assignee: Andrew Purtell
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14205.patch
>
>
> The tracking of execution time of coprocessor methods introduced in 
> HBASE-11516 introduces 2 calls to System.nanoTime() per coprocessor method 
> per coprocessor. This is resulting in a serious performance bottleneck in 
> certain scenarios.
> For example consider the scenario where many rows are being ingested (PUT) in 
> a table which has multiple coprocessors (we have up to 20 coprocessors). This 
> results in 8 extra calls to System.nanoTime() per coprocessor (prePut, 
> postPut, postStartRegionOperation and postCloseRegionOperation) which has in 
> total (i.e. times 20) been seen to result in a 50% increase of execution time.
> I think it is generally considered bad practice to measure execution times on 
> such a small scale (per single operation). Also note that measurements are 
> taken even for coprocessors that do not even have an actual implementation 
> for certain operations, making the problem worse.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to