[
https://issues.apache.org/jira/browse/HBASE-14480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908989#comment-14908989
]
Anoop Sam John commented on HBASE-14480:
----------------------------------------
I can not see any UTs for this class as such. All tests which do HFile block
based reads will follow this path as the block data backing data structure will
be this. Any way I will add a UT for this class and put a new patch.
> Small optimization in SingleByteBuff
> ------------------------------------
>
> Key: HBASE-14480
> URL: https://issues.apache.org/jira/browse/HBASE-14480
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-14480.patch
>
>
> We do read from this using Unsafe based reads on underlying BB. The
> UnsafeAccess getters having 2 branches of code for HBB and DBB and exact
> memory offset calculation varies. We can do an optimize here. We can
> initialize the reference object and exact memory offset for Unsafe reads
> while creating the SBB. We will do doing the reads on this SBB many a times.
> Each time when we do read we can use
> Unsafe.getXXX(Object, long)
> I am able to get a slight adv of 2% on this change. Small change and worth
> getting this slight gain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
