[
https://issues.apache.org/jira/browse/HBASE-14480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939743#comment-14939743
]
Hadoop QA commented on HBASE-14480:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12764572/HBASE-14480_V2.patch
against master branch at commit 76463a36f5648f42cdcf64019a825c1e3f0c4fe1.
ATTACHMENT ID: 12764572
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:red}-1 javac{color}. The applied patch generated 28 javac compiler
warnings (more than the master's current 26 warnings).
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/15840//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/15840//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/15840//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/15840//console
This message is automatically generated.
> Small optimization in SingleByteBuff
> ------------------------------------
>
> Key: HBASE-14480
> URL: https://issues.apache.org/jira/browse/HBASE-14480
> Project: HBase
> Issue Type: Sub-task
> Components: regionserver, Scanners
> Affects Versions: 2.0.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-14480.patch, HBASE-14480_V2.patch,
> HBASE-14480_V2.patch
>
>
> We do read from this using Unsafe based reads on underlying BB. The
> UnsafeAccess getters having 2 branches of code for HBB and DBB and exact
> memory offset calculation varies. We can do an optimize here. We can
> initialize the reference object and exact memory offset for Unsafe reads
> while creating the SBB. We will do doing the reads on this SBB many a times.
> Each time when we do read we can use
> Unsafe.getXXX(Object, long)
> I am able to get a slight adv of 2% on this change. Small change and worth
> getting this slight gain.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
