[ 
https://issues.apache.org/jira/browse/HBASE-14367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941020#comment-14941020
 ] 

Hadoop QA commented on HBASE-14367:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12764743/HBASE-14367-branch-1.2.v3.patch
  against branch-1.2 branch at commit 030ae5f0415b97e5da688c1432ed53fd56990194.
  ATTACHMENT ID: 12764743

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +       * <code>rpc SetNormalizerRunning(.SetNormalizerRunningRequest) 
returns (.SetNormalizerRunningResponse);</code>
+       * <code>rpc IsNormalizerEnabled(.IsNormalizerEnabledRequest) returns 
(.IsNormalizerEnabledResponse);</code>
+     * <code>rpc SetNormalizerRunning(.SetNormalizerRunningRequest) returns 
(.SetNormalizerRunningResponse);</code>
+     * <code>rpc IsNormalizerEnabled(.IsNormalizerEnabledRequest) returns 
(.IsNormalizerEnabledResponse);</code>

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15858//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15858//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15858//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/15858//console

This message is automatically generated.

> Add normalization support to shell
> ----------------------------------
>
>                 Key: HBASE-14367
>                 URL: https://issues.apache.org/jira/browse/HBASE-14367
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer, shell
>    Affects Versions: 1.1.2
>            Reporter: Lars George
>            Assignee: Mikhail Antonov
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14367-branch-1.2.v1.patch, 
> HBASE-14367-branch-1.2.v2.patch, HBASE-14367-branch-1.2.v3.patch, 
> HBASE-14367.patch
>
>
> https://issues.apache.org/jira/browse/HBASE-13103 adds support for setting a 
> normalization flag per {{HTableDescriptor}}, along with the server side chore 
> to do the work.
> What is lacking is to easily set this from the shell, right now you need to 
> use the Java API to modify the descriptor. This issue is to add the flag as a 
> known attribute key and/or other means to toggle this per table.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to