[
https://issues.apache.org/jira/browse/HBASE-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138049#comment-13138049
]
Hadoop QA commented on HBASE-4680:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500825/HBASE-4680.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/83//console
This message is automatically generated.
> FSUtils.isInSafeMode() checks should operate on HBase root dir, where we have
> permissions
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-4680
> URL: https://issues.apache.org/jira/browse/HBASE-4680
> Project: HBase
> Issue Type: Bug
> Components: util
> Affects Versions: 0.92.0
> Reporter: Gary Helmling
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: HBASE-4680.patch
>
>
> The HDFS safe mode check workaround introduced by HBASE-4510 performs a
> {{FileSystem.setPermission()}} operation on the root directory ("/") when
> attempting to trigger a {{SafeModeException}}. As a result, it requires
> superuser privileges when running with DFS permission checking enabled.
> Changing the operations to act on the HBase root directory should be safe,
> since the master process must have write access to it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
