[
https://issues.apache.org/jira/browse/HBASE-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958070#comment-14958070
]
stack commented on HBASE-14608:
-------------------------------
Thanks [~chenheng]
I see at least that over in HBASE-14600 I should have added this:
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java
index 71bd601..18dda51 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestWALProcedureStoreOnHDFS.java
@@ -195,6 +195,7 @@ public class TestWALProcedureStoreOnHDFS {
if (msg != null && msg.toLowerCase().contains("sync aborted") && i >
50) {
return;
}
+ throw re;
}
waitForNumReplicas(3);
Thread.sleep(100);
I should add log when this condition happens too so it is clear. Let me add as
addendum.
But you seem to be talking about something else.... we do a return after
catching the RuntimeException so should not be doing the isRunning unless the
RuntimeException was not the one we were looking for?
> testWalRollOnLowReplication has some risk to assert failed after HBASE-14600
> ----------------------------------------------------------------------------
>
> Key: HBASE-14608
> URL: https://issues.apache.org/jira/browse/HBASE-14608
> Project: HBase
> Issue Type: Bug
> Reporter: Heng Chen
> Attachments: HBASE-14608.patch
>
>
> After HBASE-14600, we catch runtime exception if dn recover slowly, but it
> has some risk to assert failed.
> For example, https://builds.apache.org/job/HBase-TRUNK/6907/testReport/
> The reason is we catch the exception, but in {{WALProcedureStore}}, it will
> still stop the Procedure. So when we assert stop.isRunning, it will failed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
