[ 
https://issues.apache.org/jira/browse/HBASE-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958096#comment-14958096
 ] 

Heng Chen commented on HBASE-14608:
-----------------------------------

[~stack]  If i <50,  the sync abort exception will be catched,  but in 
{{WALProcedureStore}}, it will still stop the procedureStore.  So when we 
assert 
{code}
    assertTrue(store.isRunning());
{code}
It will be failed.

if we add {{throw e}} just like you mention, sync abort exception will still 
interrupt this testcase 

> testWalRollOnLowReplication has some risk to assert failed after HBASE-14600
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-14608
>                 URL: https://issues.apache.org/jira/browse/HBASE-14608
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>         Attachments: HBASE-14608.patch, HBASE-14608_v1.patch
>
>
> After HBASE-14600,  we catch runtime exception if dn recover slowly,  but it 
> has some risk to assert failed.
> For example, https://builds.apache.org/job/HBase-TRUNK/6907/testReport/
> The reason is we catch the exception, but in {{WALProcedureStore}}, it will 
> still stop the Procedure. So when we assert stop.isRunning, it will failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to