[
https://issues.apache.org/jira/browse/HBASE-14643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964511#comment-14964511
]
ramkrishna.s.vasudevan commented on HBASE-14643:
------------------------------------------------
bq. if (lastKey == null) {
The check for null case for last key and first key is not needed because any
way you have explicitly set the first key and last key. I think we can safely
remove it.
bq.if (CellComparator.COMPARATOR.compare(splitKey, lastKey) > 0)
This is fine for now but when META split happens then this may cause some
issue. So similar to lastKey and firstKey can you set the comparator also on
the storeFile itself instead of that being in the reader?
> Avoid Splits from once again opening a closed reader for fetching the first
> and last key
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-14643
> URL: https://issues.apache.org/jira/browse/HBASE-14643
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Heng Chen
> Attachments: HBASE-14643.patch, HBASE-14643_v1.patch,
> HBASE-14643_v2.patch, HBASE-14643_v3.patch
>
>
> Currently split flow is such that we close the parent region and all its
> store file readers are also closed. After that inorder to split the
> reference files we need the first and last keys for which once again open the
> readers on those store files. This could be costlier operation considering
> the fact that it has to contact the HDFS for this close and open operation.
> This JIRA is to see if we can improve this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
