[
https://issues.apache.org/jira/browse/HBASE-14643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14964518#comment-14964518
]
Anoop Sam John commented on HBASE-14643:
----------------------------------------
bq.if (CellComparator.COMPARATOR.compare(splitKey, lastKey) > 0) {
As of now this change is ok as we don't allow META region to split. But when we
do, this won't hold true
bq.// firstKey and lastkey will be set when closeReader.
When StoreFile is immutable, why not store it on open? Store it while only
close looks odd. If we do set it on open, can the redundant null check as in
patch can go away? I mean below one
{quote}
if (lastKey == null) {
588 lastKey = f.createReader().getLastKey();
589 if (lastKey == null) {
{quote}
> Avoid Splits from once again opening a closed reader for fetching the first
> and last key
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-14643
> URL: https://issues.apache.org/jira/browse/HBASE-14643
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: Heng Chen
> Attachments: HBASE-14643.patch, HBASE-14643_v1.patch,
> HBASE-14643_v2.patch, HBASE-14643_v3.patch
>
>
> Currently split flow is such that we close the parent region and all its
> store file readers are also closed. After that inorder to split the
> reference files we need the first and last keys for which once again open the
> readers on those store files. This could be costlier operation considering
> the fact that it has to contact the HDFS for this close and open operation.
> This JIRA is to see if we can improve this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
