[
https://issues.apache.org/jira/browse/HBASE-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968792#comment-14968792
]
Apekshit Sharma commented on HBASE-14675:
-----------------------------------------
+1
Had a quick glance through, just few nits:
Params are split across lines and 8 space align instead of 4.
RegionMergeTransactionImpl:426
TestFromClientSide:418
Missing comments (in case not removed intentionally)
TestFromClientSide:1897
TestRowProcessorEndpoint:138
Alignment:
TestHCM:998 - Since it's fixing alignment, the next two lines are misaligned
too.
TestScannerTimeout:70 - it's 'for' that needs to be aligned
TestFilter:1819 - new lines are misaligned.
TestCellCounter:124 & 164 & 204 - The block will look funny due staggered
alignment of rows.
I believe there are few lines which exceed 100 char limit, but pre-commit test
should notify those.
> Excise deprecated Put#add(...) and replace with Put#addColumn(...)
> ------------------------------------------------------------------
>
> Key: HBASE-14675
> URL: https://issues.apache.org/jira/browse/HBASE-14675
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 2.0.0
>
> Attachments: hbase-14675.patch
>
>
> The Put API changed from #add(...) to #addColumn(...). This updates all
> instances of it and removes it from the Put (which was added for hbase 1.0.0)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
