[
https://issues.apache.org/jira/browse/HBASE-14675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14968919#comment-14968919
]
Hadoop QA commented on HBASE-14675:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12767984/hbase-14675.patch
against master branch at commit 6a90e7b43ba7a0eb54b446ffa1067cf5858ee8c6.
ATTACHMENT ID: 12767984
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 529
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1748 checkstyle errors (more than the master's current 1747 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ putOfMerged.addColumn(HConstants.CATALOG_FAMILY,
HConstants.MERGEA_QUALIFIER, regionA.toByteArray());
+ putOfMerged.addColumn(HConstants.CATALOG_FAMILY,
HConstants.MERGEB_QUALIFIER, regionB.toByteArray());
+ p.addColumn(Bytes.toBytes("col"), Bytes.toBytes("ql"),
Bytes.toBytes("value" + numberOfPuts));
+ p2.addColumn(TEST_FAMILY, Bytes.add(TEST_MULTI_CQ, Bytes.toBytes(d)),
Bytes.toBytes(d * 0.10));
+ put.addColumn(Bytes.toBytes("f1"), Bytes.toBytes("c" + j),
timestamp, Bytes.toBytes(i + "_c" + j));
+ put.addColumn(FAMILY_NAME_BYTES, Bytes.toBytes(QUALIFIER_PREFIX + i),
(long) i, Bytes.toBytes(VALUE_PREFIX + i));
+ put.addColumn(CF_BYTES, Bytes.toBytes("col" + j), ts,
Bytes.toBytes("value" + i + "_" + j + "_" + ts));
+ put.addColumn(FAMILY_BYTES, Bytes.toBytes("col" + iCol),
Bytes.toBytes("value" + iFile + "_" + iRow + "_" + iCol));
+ put.addColumn(FAMILY_BYTES, Bytes.toBytes("col" + iCol), ts +
version, Bytes.toBytes("value" + iFile + "_" + iRow + "_" + iCol));
+ outCollector.collect(outKey, new
Put(Bytes.toBytes("rowKey2")).addColumn(COLUMN_FAMILY, COLUMN_QUALIFIER,
Bytes.toBytes(name)));
{color:green}+1 site{color}. The mvn post-site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/16167//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16167//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/16167//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/16167//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16167//console
This message is automatically generated.
> Excise deprecated Put#add(...) and replace with Put#addColumn(...)
> ------------------------------------------------------------------
>
> Key: HBASE-14675
> URL: https://issues.apache.org/jira/browse/HBASE-14675
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 2.0.0
>
> Attachments: hbase-14675.patch
>
>
> The Put API changed from #add(...) to #addColumn(...). This updates all
> instances of it and removes it from the Put (which was added for hbase 1.0.0)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
