[ 
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139550#comment-13139550
 ] 

Lars Hofhansl edited comment on HBASE-4583 at 10/30/11 7:06 AM:
----------------------------------------------------------------

Here's a *sketch* of a patch.
May need some clean up but should work.

Basically the KVs of Append and Increment are applied to memstore through a 
call to the "standard" applyFamilyMapToMemstore(...); then duplicates are 
removed after the rwcc is moved forward.
Still a lot of boilerplate shared between Append and Increment.

I think the dup removal does not need to hold the regions updatesLock.readLock 
(just the lock.readLock), but I am not entirely sure.

Comments/suggestions/flames/praise are welcome. :)

                
      was (Author: lhofhansl):
    Here a *sketch* of a patch.
May need some clean up but should work.

Basically the KVs of Append and Increment are applied to memstore through a 
call to the "standard" applyFamilyMapToMemstore(...); then duplicates are 
removed after the rwcc is moved forward.
Still a lot of boilerplate shared between Append and Increment.

I think the dup removal does not need to hold the regions updatesLock.readLock 
(just the lock.readLock), but I am not entirely sure.

Comments/suggestions/flames/praise are welcome. :)

                  
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
>                 Key: HBASE-4583
>                 URL: https://issues.apache.org/jira/browse/HBASE-4583
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 4583.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a 
> client could see the results of multiple such operation mixed in the same 
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes 
> to and from the memstore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to