[
https://issues.apache.org/jira/browse/HBASE-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139641#comment-13139641
]
Ted Yu commented on HBASE-4583:
-------------------------------
Publishing on reviewboard would make reviewing much easier.
Patch looks good overall.
A few minor comments.
newFamilyMap.asMap() is called more than once in append() and increment(). We
can use a variable to hold its return and reuse the variable in place of the
second call.
Line 3948 can be omitted:
{code}
flush = isFlushSize(size);
{code}
because we have the same call at line 3964.
Same argument can be made for the call at line 3824.
In MemStore.java:
{code}
* For each KeyValue if the keyValue did already exist, with a
{code}
Should read 'if the KeyValue does already ...'
This comment in Store.java can be refined:
{code}
* qualifier exists in MemStore with a memstoreTS < the passed KV, it will be
removed.
{code}
because we only pass keyvalues to this.memstore.removeDups().
> Integrate RWCC with Append and Increment operations
> ---------------------------------------------------
>
> Key: HBASE-4583
> URL: https://issues.apache.org/jira/browse/HBASE-4583
> Project: HBase
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4583.txt
>
>
> Currently Increment and Append operations do not work with RWCC and hence a
> client could see the results of multiple such operation mixed in the same
> Get/Scan.
> The semantics might be a bit more interesting here as upsert adds and removes
> to and from the memstore.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
