[ 
https://issues.apache.org/jira/browse/HBASE-14279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993302#comment-14993302
 ] 

Hiroshi Ikeda commented on HBASE-14279:
---------------------------------------

{quote}
Currently there is only one place to call this method, it is is BucketCache.
{quote}

I think ConcurrentIndex is never appropriate for the package hbase.util. This 
is a part of BucketCahce and should be placed in the same package of 
BucketCahce, and it is better to be a package private class. (Fortunately this 
is still declared as InterfaceAudience.Private.)

Anyone would not so much complain encapsulated classes' specification as long 
as they well work together.

> Race condition in ConcurrentIndex
> ---------------------------------
>
>                 Key: HBASE-14279
>                 URL: https://issues.apache.org/jira/browse/HBASE-14279
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Hiroshi Ikeda
>            Assignee: Heng Chen
>            Priority: Minor
>         Attachments: HBASE-14279.patch, HBASE-14279_v2.patch, 
> HBASE-14279_v3.patch, HBASE-14279_v4.patch, LockStripedBag.java
>
>
> {{ConcurrentIndex.put}} and {{remove}} are in race condition. It is possible 
> to remove a non-empty set, and to add a value to a removed set. Also 
> {{ConcurrentIndex.values}} is vague in sense that the returned set sometimes 
> trace the current state and sometimes doesn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to