[ 
https://issues.apache.org/jira/browse/HBASE-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996196#comment-14996196
 ] 

Hadoop QA commented on HBASE-14749:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12771292/HBASE-14749-v2.patch
  against master branch at commit 1cbcf1175e6ce497936f12c60fb2e897833ace39.
  ATTACHMENT ID: 12771292

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 
2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the 
total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +  echo "Usage: graceful_stop.sh [--config <conf-dir>] [-e] [--restart 
[--reload]] [--thrift] [--rest] <hostname>"
+  echo " n|noack        Enable noAck mode in RegionMover. This is a best 
effort mode for moving regions"
+  echo " movetimeout xx Timeout for moving regions. If regions are not moved 
by the timeout value, exit with error. Default value is INT_MAX."
+HBASE_NOEXEC=true "$bin"/hbase --config ${HBASE_CONF_DIR} 
org.apache.hadoop.hbase.util.RegionMover --filename $filename --maxthreads 
$maxthreads $noack --operation "unload" --timeout $movetimeout 
--regionserverhost $hostname
+    HBASE_NOEXEC=true "$bin"/hbase --config ${HBASE_CONF_DIR} 
org.apache.hadoop.hbase.util.RegionMover --filename $filename --maxthreads 
$maxthreads $noack --operation "load" --timeout $movetimeout --regionserverhost 
$hostname
+usage_str="Usage: `basename $0` [--config <hbase-confdir>] [--rs-only] 
[--master-only] [--graceful [--maxthreads xx] [--noack] [--movetimeout]]"
+        "$bin"/graceful_stop.sh --config ${HBASE_CONF_DIR} --restart --reload 
--maxthreads ${RR_MAXTHREADS} ${RR_NOACK} --movetimeout ${RR_MOVE_TIMEOUT} 
$hostname

  {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16456//testReport/
Release Findbugs (version 2.0.3)        warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16456//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16456//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/16456//console

This message is automatically generated.

> Make changes to region_mover.rb to use RegionMover Java tool
> ------------------------------------------------------------
>
>                 Key: HBASE-14749
>                 URL: https://issues.apache.org/jira/browse/HBASE-14749
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14749-v2.patch, HBASE-14749.patch, 
> HBASE-14749.patch
>
>
> With HBASE-13014 in, we can now replace the ruby script such that it invokes 
> the Java Tool. Also expose timeout and no-ack mode which were added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to