[
https://issues.apache.org/jira/browse/HBASE-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031798#comment-15031798
]
Samir Ahmic commented on HBASE-14749:
-------------------------------------
I have tested patch on cluster (master branch) overall looks good. Only thing
that we could change is to get rid of this exception while regionserver is
starting:
{code}
2015-11-30 14:32:35,575 INFO [pool-1-thread-1] util.RegionMover:
hostname=hnode5 is not up yet, waiting
java.lang.Exception: Server hnode5:16020 is not in list of online
servers(Offline/Incorrect)
at
org.apache.hadoop.hbase.util.RegionMover.stripServer(RegionMover.java:815)
at
org.apache.hadoop.hbase.util.RegionMover.loadRegions(RegionMover.java:380)
at
org.apache.hadoop.hbase.util.RegionMover.access$1300(RegionMover.java:75)
at
org.apache.hadoop.hbase.util.RegionMover$Load.call(RegionMover.java:264)
at
org.apache.hadoop.hbase.util.RegionMover$Load.call(RegionMover.java:245)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{code}
personally i don't mind seeing what is going on but some users may think that
something went wrong.
Regarding applying patch on master branch there were changes in
rolling_restart.sh in meantime HBASE-14523 i had to manually change some lines.
[~abhishek.chouhan] it would be great if you can rebase your branch (git pull
--rebase origin master) and create new patch.
> Make changes to region_mover.rb to use RegionMover Java tool
> ------------------------------------------------------------
>
> Key: HBASE-14749
> URL: https://issues.apache.org/jira/browse/HBASE-14749
> Project: HBase
> Issue Type: Improvement
> Reporter: Abhishek Singh Chouhan
> Assignee: Abhishek Singh Chouhan
> Fix For: 2.0.0
>
> Attachments: HBASE-14749-v2.patch, HBASE-14749-v3.patch,
> HBASE-14749-v3.patch, HBASE-14749.patch, HBASE-14749.patch
>
>
> With HBASE-13014 in, we can now replace the ruby script such that it invokes
> the Java Tool. Also expose timeout and no-ack mode which were added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
