[ 
https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005202#comment-15005202
 ] 

stack commented on HBASE-14769:
-------------------------------

So you keep this because it was not deprecated though it should have been? 
[~appy]

  public Pair<Integer, Integer> getAlterStatus(final byte[] tableName) throws 
IOException {

Want to add @deprecated as part of this patch or do you want to do that in new 
issue?

What is parent doc in below?

  // See parent doc for deprecation timeline.

Ok to remove this one?

3290      public void snapshot(final String snapshotName,               
3291                           final String tableName) throws IOException,      
        
3292          SnapshotCreationException, IllegalArgumentException {             
3293        snapshot(snapshotName, TableName.valueOf(tableName),                
3294            SnapshotDescription.Type.FLUSH);                
3295      }

and a few of the other snapshot methods being removed?

This is a great cleanup patch. Lets get it in [~appy]



> Remove unused functions and duplicate javadocs from HBaseAdmin 
> ---------------------------------------------------------------
>
>                 Key: HBASE-14769
>                 URL: https://issues.apache.org/jira/browse/HBASE-14769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-14769-master-v2.patch, 
> HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch, 
> HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used 
> anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in 
> Admin.java. Since javadocs are automatically inherited from the interface 
> class, we can remove these redundant 100s of lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to