[ 
https://issues.apache.org/jira/browse/HBASE-14769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027196#comment-15027196
 ] 

Ashish Singhi commented on HBASE-14769:
---------------------------------------

bq. But given the functions being removed are long dead (we moved to TableName 
two years ago?)
I understand this, but as the method getHBaseAdmin in HBTU is getting 
deprecated now as part of this patch I think we should not directly remove it 
instead we can mark them as deprecated and comment it that we are safe to 
remove it in 3.0.

Thanks.

> Remove unused functions and duplicate javadocs from HBaseAdmin 
> ---------------------------------------------------------------
>
>                 Key: HBASE-14769
>                 URL: https://issues.apache.org/jira/browse/HBASE-14769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14769-master-v2.patch, 
> HBASE-14769-master-v3.patch, HBASE-14769-master-v4.patch, 
> HBASE-14769-master-v5.patch, HBASE-14769-master.patch
>
>
> HBaseAdmin is marked private, so removing the functions not being used 
> anywhere.
> Also, the javadocs of overridden functions are same as corresponding ones in 
> Admin.java. Since javadocs are automatically inherited from the interface 
> class, we can remove these redundant 100s of lines.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to