[
https://issues.apache.org/jira/browse/HBASE-14719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15018439#comment-15018439
]
Matteo Bertozzi commented on HBASE-14719:
-----------------------------------------
should we have a different class for procedure metrics? there will be way more
in the future.
for example snapshot on master has its own subsection (see
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetricsSnapshot.java)
I think getWALFileSize() should be in ProcedureWALStore or at least it has to
change to fix something around concurrency. I think we just return the pointer
to the list that we have in the Store class, since that was supposed to be
visible only for testing.
also, the current WAL + all the wals created from master startup will always
return 0 as size. since we don't have that FileStatus object for them and we
don't update it.
> Add metric for number of MasterProcWALs
> ---------------------------------------
>
> Key: HBASE-14719
> URL: https://issues.apache.org/jira/browse/HBASE-14719
> Project: HBase
> Issue Type: Improvement
> Reporter: Elliott Clark
> Assignee: Vrishal Kulkarni
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-14719.patch
>
>
> Lets add monitoring to this so that we can see when it starts.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
