[
https://issues.apache.org/jira/browse/HBASE-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023874#comment-15023874
]
Gary Helmling commented on HBASE-14866:
---------------------------------------
{code}
+import org.apache.htrace.fasterxml.jackson.databind.ObjectMapper;
{code}
It looks like the latest patch is using a shaded class from an HTrace
dependency. I don't think we should be using a shaded class. I am also not a
fan of serializing multiple configuration properties into a single
configuration value.
I was planning to instead prefix the {{ReplicationPeerConfig}} configuration
properties with a set prefix (say "hbase.verifyrep.peer."), then use the
{{HBaseConfiguration.subset()}} method being added in HBASE-14821 to extract
the prefixed values in the map method and merge them back in to the peer
configuration created.
> VerifyReplication should use peer configuration in peer connection
> ------------------------------------------------------------------
>
> Key: HBASE-14866
> URL: https://issues.apache.org/jira/browse/HBASE-14866
> Project: HBase
> Issue Type: Improvement
> Components: Replication
> Reporter: Gary Helmling
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-14866.patch, HBASE-14866_v1.patch
>
>
> VerifyReplication uses the replication peer's configuration to construct the
> ZooKeeper quorum address for the peer connection. However, other
> configuration properties in the peer's configuration are dropped. It should
> merge all configuration properties from the {{ReplicationPeerConfig}} when
> creating the peer connection and obtaining a credentials for the peer cluster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
