[ 
https://issues.apache.org/jira/browse/HBASE-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037134#comment-15037134
 ] 

Heng Chen commented on HBASE-14866:
-----------------------------------

{quote}
Should transformClusterKey just use standardizeZKQuorumServerString rather than 
having two different cases?
{quote}
It seems transformClusterKey has use it yet. [~eclark]

btw.  
why not move  buildZKQuorumServerString and standardizeZKQuorumServerString 
into ZKUtil?   
As public method in HBaseConfiguration,  It is weird.

{quote}
Most of these changes to HBaseConfiguration seem to be very replication 
specific. Should we have a different class for replication based configuration, 
so that HBaseConfiguration doesn't get too unwieldy?
{quote}
Agreed. Maybe we need something like ReplicationUtils ? 






> VerifyReplication should use peer configuration in peer connection
> ------------------------------------------------------------------
>
>                 Key: HBASE-14866
>                 URL: https://issues.apache.org/jira/browse/HBASE-14866
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-14866.patch, HBASE-14866_v1.patch, 
> hbase-14866-v4.patch, hbase-14866_v2.patch, hbase-14866_v3.patch
>
>
> VerifyReplication uses the replication peer's configuration to construct the 
> ZooKeeper quorum address for the peer connection.  However, other 
> configuration properties in the peer's configuration are dropped.  It should 
> merge all configuration properties from the {{ReplicationPeerConfig}} when 
> creating the peer connection and obtaining a credentials for the peer cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to