[
https://issues.apache.org/jira/browse/HBASE-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031421#comment-15031421
]
Gary Helmling commented on HBASE-14886:
---------------------------------------
[~eclark] [~chenheng], this change already encapsulates the use of
applyClusterKeyToConf() in the replication code, except for one usage in
VerifyReplication (HBASE-14866).
However, {{ZKUtil.applyClusterKeyToConf()}} is still used in cases outside of
replication (CopyTable, SyncTable, TableOutputFormat). These are all valid
uses for inter-cluster copying where no replication configuration needs to
exist. Since I've already had to fix up CopyTable / TableOutputFormat, I agree
that those cases could be better encapsulated as well. But those seem distinct
from the replication related cases here. I'll take another look at those and
see if we can clean them up in a separate issue.
> ReplicationAdmin does not use full peer configuration
> -----------------------------------------------------
>
> Key: HBASE-14886
> URL: https://issues.apache.org/jira/browse/HBASE-14886
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Critical
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: hbase-14886-v1.patch, hbase-14886.patch
>
>
> In {{listValidReplicationPeers()}}, we're creating the peer {{Configuration}}
> based on the source connection configuration and simply applying the peer ZK
> cluster key. This causes any additional properties present in the
> {{ReplicationPeerConfig}} configuration to not be applied.
> We should instead be using the configuration returned by
> {{ReplicationPeers.getPeerConf()}}, which we already call in that method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
