[
https://issues.apache.org/jira/browse/HBASE-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067695#comment-15067695
]
Hadoop QA commented on HBASE-15026:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org
against master branch at commit 6e2c5d216eb1f4cacad7c5d7ed43b67785cabb67.
ATTACHMENT ID: http:
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation, build,
or dev-support patch that doesn't require tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/16968//console
This message is automatically generated.
> The default value of "hbase.regions.slop" in docs is obsolete
> -------------------------------------------------------------
>
> Key: HBASE-15026
> URL: https://issues.apache.org/jira/browse/HBASE-15026
> Project: HBase
> Issue Type: Bug
> Components: Balancer
> Affects Versions: 1.1.2
> Reporter: Tianyin Xu
> Attachments: HBASE.15026.patch.001
>
>
> The default value of {{hbase.regions.slop}} is {{0.001}} in
> {{StochasticLoadBalancer}} (which is the default setting of
> {{hbase.master.loadbalancer.class}}).
> However, in the docs (both {{hbase-default.xml}} and [online
> docs|http://hbase.apache.org/book.html#config.files]), the default value is
> {{0.2}}. This value is specified in {{BaseLoadBalancer}} (which is an
> abstract class) and is inherited by {{SimpleLoadBalancer}}. However, as
> {{SimpleLoadBalancer}} is no longer used as the default load balancer, the
> doc is obsolete.
> The code structure is:
> {code:title=BaseLoadBalancer.java|borderStyle=solid}
> public abstract class BaseLoadBalancer implements LoadBalancer {
> ...
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2);
> }
> {code}
> {code:title=StochasticLoadBalancer.java|borderStyle=solid}
> public class StochasticLoadBalancer extends BaseLoadBalancer {
> ...
> @Override
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", 0.001F);
> }
> {code}
> I suggest to make the manual entry of {{hbase.regions.slop}} specify the
> different default values in different balancer classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
