[
https://issues.apache.org/jira/browse/HBASE-15026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15071748#comment-15071748
]
Hadoop QA commented on HBASE-15026:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12779526/HBASE.15026.patch
against master branch at commit 1c7e9ec124ab19d3c727d8294a8022d7b936bbfc.
ATTACHMENT ID: 12779526
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0
2.7.1)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not generate new
checkstyle errors.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn post-site goal succeeds with this
patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 zombies{color}. No zombie tests found running at the end of
the build.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/17031//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/17031//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/17031//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/17031//console
This message is automatically generated.
> The default value of "hbase.regions.slop" in docs is obsolete
> -------------------------------------------------------------
>
> Key: HBASE-15026
> URL: https://issues.apache.org/jira/browse/HBASE-15026
> Project: HBase
> Issue Type: Bug
> Components: Balancer
> Affects Versions: 1.1.2
> Reporter: Tianyin Xu
> Priority: Minor
> Attachments: HBASE.15026.patch
>
>
> The default value of {{hbase.regions.slop}} is {{0.001}} in
> {{StochasticLoadBalancer}} (which is the default setting of
> {{hbase.master.loadbalancer.class}}).
> However, in the docs (both {{hbase-default.xml}} and [online
> docs|http://hbase.apache.org/book.html#config.files]), the default value is
> {{0.2}}. This value is specified in {{BaseLoadBalancer}} (which is an
> abstract class) and is inherited by {{SimpleLoadBalancer}}. However, as
> {{SimpleLoadBalancer}} is no longer used as the default load balancer, the
> doc is obsolete.
> The code structure is:
> {code:title=BaseLoadBalancer.java|borderStyle=solid}
> public abstract class BaseLoadBalancer implements LoadBalancer {
> ...
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", (float) 0.2);
> }
> {code}
> {code:title=StochasticLoadBalancer.java|borderStyle=solid}
> public class StochasticLoadBalancer extends BaseLoadBalancer {
> ...
> @Override
> protected void setSlop(Configuration conf) {
> this.slop = conf.getFloat("hbase.regions.slop", 0.001F);
> }
> {code}
> I suggest to make the manual entry of {{hbase.regions.slop}} specify the
> different default values in different balancer classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
