[
https://issues.apache.org/jira/browse/HBASE-15027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072954#comment-15072954
]
Ted Yu commented on HBASE-15027:
--------------------------------
Test failure in TestHRegionReplayEvents is reproducible. Please investigate.
{code}
2307 processCompactedfiles(copyCompactedfiles);
{code}
Suggest camel casing the 'f' in files.
{code}
2326 LOG.debug("Removing the compacted store files " + compactedfiles);
{code}
The above wouldn't log each file in the collection, right ?
Overall, approach looks good.
> Refactor the way the CompactedHFileDischarger threads are created
> -----------------------------------------------------------------
>
> Key: HBASE-15027
> URL: https://issues.apache.org/jira/browse/HBASE-15027
> Project: HBase
> Issue Type: Bug
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0
>
> Attachments: HBASE-15027.patch, HBASE-15027_1.patch,
> HBASE-15027_2.patch, HBASE-15027_3.patch, HBASE-15027_3.patch
>
>
> As per suggestion given over in HBASE-14970, if we need to create a single
> thread pool service for the CompactionHFileDischarger we need to create an
> exectuor service in the RegionServer level and create discharger handler
> threads (Event handlers) and pass the Event to the new Exectuor service that
> we create for the compaction hfiles discharger. What should be the default
> number of threads here? If a HRS holds 100 of regions - will 10 threads be
> enough? This issue will try to resolve this with tests and discussions and
> suitable patch will be updated in HBASE-14970 for branch-1 once this is
> committed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
