[
https://issues.apache.org/jira/browse/HBASE-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075731#comment-15075731
]
Eungsop Yoo commented on HBASE-15055:
-------------------------------------
I see. It may cause more major compactions.
But the increased number of times of major compactions would be limited at most
once (per each region) per HConstants.MAJOR_COMPACTION_PERIOD(7 days) by the
below code.
{code}
public class RatioBasedCompactionPolicy extends CompactionPolicy {
...
public boolean isMajorCompaction(final Collection<StoreFile> filesToCompact)
throws IOException {
...
long lowTimestamp = StoreUtils.getLowestTimestamp(filesToCompact);
long now = System.currentTimeMillis();
if (lowTimestamp > 0l && lowTimestamp < (now - mcTime)) {
...
{code}
I think it isn't too much. How about you?
> Major compaction is not triggered when both of TTL and
> hbase.hstore.compaction.max.size are set
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-15055
> URL: https://issues.apache.org/jira/browse/HBASE-15055
> Project: HBase
> Issue Type: Bug
> Reporter: Eungsop Yoo
> Priority: Minor
> Attachments: HBASE-15055-v1.patch, HBASE-15055-v2.patch,
> HBASE-15055.patch
>
>
> Some large files may be skipped by hbase.hstore.compaction.max.size in
> candidate selection. It causes skipping of major compaction. So the TTL
> expired records are still remained in the disks and keep consuming disks.
> To resolve this issue, I suggest that to skip large files only if there is no
> TTL expired record.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
