[
https://issues.apache.org/jira/browse/HBASE-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085334#comment-15085334
]
Ted Yu commented on HBASE-15055:
--------------------------------
{code}
150 // Do not skip large files when the sum of the size of TTL expired
store files are greater
151 // then threshold. Major compaction should be triggered to delete
TTL expired records.
{code}
'are greater' -> 'is greater'
'then threshold' -> 'than threshold'
Can you add release note for the new parameter ?
In the patch, variable name has threshold as suffix - maybe use same suffix for
parameter name ? Release note can include variant of the above javadoc.
> Major compaction is not triggered when both of TTL and
> hbase.hstore.compaction.max.size are set
> -----------------------------------------------------------------------------------------------
>
> Key: HBASE-15055
> URL: https://issues.apache.org/jira/browse/HBASE-15055
> Project: HBase
> Issue Type: Bug
> Reporter: Eungsop Yoo
> Assignee: Eungsop Yoo
> Priority: Minor
> Attachments: HBASE-15055-v1.patch, HBASE-15055-v2.patch,
> HBASE-15055-v3.patch, HBASE-15055-v4.patch, HBASE-15055.patch
>
>
> Some large files may be skipped by hbase.hstore.compaction.max.size in
> candidate selection. It causes skipping of major compaction. So the TTL
> expired records are still remained in the disks and keep consuming disks.
> To resolve this issue, I suggest that to skip large files only if there is no
> TTL expired record.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
