[ 
https://issues.apache.org/jira/browse/HBASE-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082120#comment-15082120
 ] 

stack commented on HBASE-14888:
-------------------------------

Thanks [~mbertozzi]

Let me do same as for table then by adding an async version.

bq. the getOperationType() was not supposed to be an enum. 

Yeah... I just had to reuse some of the 'user-friendly descriptions' and was 
going to do a define for CREATE, DELETE, etc... just did enum for the 
toString... let me back it out since it might confuse.

bq. where is the Future<ProcedureInfo> returned by the ClusterSchema gone?

Removed it. Thats the 'simplification' I talked about in the comment (not 
having it makes stuff simpler serverside). Some of the contention around 
earlier versions of this patch evaporates when no 
Future<ProcedureInfo>/ProcedureFuture thing too. On other hand, if I had it, 
this blockOnProcedure stuff could be done a bit cleaner.

Let me do up a new version.

Thanks for the review.


> ClusterSchema: Add Namespace Operations
> ---------------------------------------
>
>                 Key: HBASE-14888
>                 URL: https://issues.apache.org/jira/browse/HBASE-14888
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 
> 0001-Add-in-a-ClusterSchema-Interface.-It-will-have-all-Av2.patch, 
> 14888.patch, 14888.v8.txt, 14888v11.patch, 14888v12.patch, 14888v13.patch, 
> 14888v14.patch, 14888v15.patch, 14888v16.patch, 14888v17.txt, 14888v18.patch, 
> 14888v19.patch, 14888v20.patch, 14888v3.txt, 14888v4.txt, 14888v5.txt, 
> 14888v6.txt, 14888v7.txt, 14888v9.txt
>
>
> Add in a ClusterSchema Interface. It will have all API for all cluster 
> manipulation; adding namespaces, tables, amending column families, etc. The 
> idea is to gather up our mess and put it all behind a tidy API that all works 
> the same way whatever you changing returning a Future to wait on and behind 
> the scenes driving Procedures.
> This patch does namespace operations first.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to