[
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143781#comment-13143781
]
Phabricator commented on HBASE-4742:
------------------------------------
Karthik has commented on the revision "[jira] [HBASE-4742] Split dead server's
log in parallel".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:65
Could we write a one-line comment about the state? I think ABORT means there is
no need to split any logs, right?
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:331
Might be missing something here... this break will just cause the operation to
return as if it succeeded, but log splitting is still in progress right? We
would then proceed to open the regions without ensuring this is completed?
Maybe we need:
this.requeue();
return false;
REVISION DETAIL
https://reviews.facebook.net/D237
> Split dead server's log in parallel
> -----------------------------------
>
> Key: HBASE-4742
> URL: https://issues.apache.org/jira/browse/HBASE-4742
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D237.1.patch
>
>
> When one region server goes down, the master will shutdown the region server
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the
> dead servers in parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
