[
https://issues.apache.org/jira/browse/HBASE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144536#comment-13144536
]
Phabricator commented on HBASE-4742:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4742] Split dead server's
log in parallel".
Liyin, good stuff! Some comments inline:
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:56
Should this field be remove now that it is superseded by logSplitResult?
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:337
Succeed to split -> Succeeded splitting
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:82
Indentation
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:93
Space between ) and op
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:133
Space between try and {
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:135
1. Please don't ignore the exception. Log it at least. What is the expected
exception here? Can we catch only one particular kind of exception and fail the
unit test for all other exceptions?
2. Indentation
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:52
This variable is never read
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:68
Insert an empty line here
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:347-348
Would it make sense to throw an IOException instead?
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:113
This variable is never read
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:143
all the listener -> all the listeners
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:49
Rename to numClosedRegionServers. Otherwise it is not clear whether this is a
regionserver ID or the number of them.
src/test/java/org/apache/hadoop/hbase/master/TestMultiRegionServerShutDown.java:72
Line longer than 80 characters (this is currently not reported by this
Phabricator setup).
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:333
Are you sure that it is OK to requeue this split request before the worker
thread splitting this region server's logs completes?
src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java:312
Instead of spawning threads in an uncontrolled way like this, it would be nice
to use an ExecutorService. Also, if there are hundreds of logs to split, we
would probably like to restrict the number of concurrent log-splitting threads,
which can also be achieved using a thread-pool executor service.
REVISION DETAIL
https://reviews.facebook.net/D237
> Split dead server's log in parallel
> -----------------------------------
>
> Key: HBASE-4742
> URL: https://issues.apache.org/jira/browse/HBASE-4742
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D237.1.patch, D237.2.patch, D237.3.patch, D237.4.patch
>
>
> When one region server goes down, the master will shutdown the region server
> and split its log.
> However, splitting log is a blocking call and it would take some time.
> If more than one region server go down, the master will split its log one by
> one, which is not efficient.
> Since we have the distributed log split, we could split these logs from the
> dead servers in parallel.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
