[
https://issues.apache.org/jira/browse/HBASE-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110489#comment-15110489
]
Yu Li commented on HBASE-15148:
-------------------------------
>From the console output:
{noformat}
============================================================================
============================================================================
Patch findbugs detection
============================================================================
============================================================================
cd
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/hbase-server
/home/jenkins/tools/maven/latest/bin/mvn
-Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-1 -DHBasePatchProcess
test-compile findbugs:findbugs -DskipTests=true >
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/patchprocess/patch-findbugs-hbase-server.txt
2>&1
Elapsed: 2m 50s
Starting with
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/patchprocess/branch-findbugs-hbase-server-warnings.xml
Merging
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/patchprocess/patch-findbugs-hbase-server-warnings.xml
Writing
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/patchprocess/combined-findbugs-hbase-server.xml
Found 0 new Findbugs warnings and 1 newly fixed warnings.
{noformat}
The findbugs issue got resolved with the patch. It seems the output of HadoopQA
report has some problem.
Regarding the UT failures, none of them are introduced by change here.
> Resolve IS2_INCONSISTENT_SYNC findbugs warnings in
> AuthenticationTokenSecretManager
> -----------------------------------------------------------------------------------
>
> Key: HBASE-15148
> URL: https://issues.apache.org/jira/browse/HBASE-15148
> Project: HBase
> Issue Type: Bug
> Reporter: Yu Li
> Assignee: Yu Li
> Fix For: 2.0.0, 1.2.0, 1.3.0
>
> Attachments: HBASE-15148.patch
>
>
> After efforts in HBASE-15118, we still see IS2_INCONSISTENT_SYNC warning in
> AuthenticationTokenSecretManager in [HadoopQA report |
> https://builds.apache.org/job/PreCommit-HBASE-Build/197/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html]
> for HBASE-13960:
> {noformat}
> In class
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager
> Field
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.lastKeyUpdate
> Synchronized 50% of the time
> Unsynchronized access at AuthenticationTokenSecretManager.java:[line 343]
> Synchronized access at AuthenticationTokenSecretManager.java:[line 278]
> {noformat}
> Checking the code, we could see {{synchronized (this)}} in line 343 is
> synchronizing on the instance of the subclass
> {{AuthenticationTokenSecretManager$LeaderElector}} while {{lastKeyUpdate}} is
> a variable of the parent class instance
> Will fix the issue in this JIRA
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
