[ 
https://issues.apache.org/jira/browse/HBASE-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112102#comment-15112102
 ] 

Yu Li commented on HBASE-15148:
-------------------------------

In the latest report, from the log of the failed TestGenerateDelegationToken 
case:
{noformat}
java.net.BindException: Address already in use
        at sun.nio.ch.Net.bind0(Native Method)
        at sun.nio.ch.Net.bind(Net.java:444)
        at sun.nio.ch.Net.bind(Net.java:436)
{noformat}
I should be an env issue

In previous report, there are mainly two failures: 
TestRegionMergeTransactionOnCluster and TestStochasticLoadBalancer, and they 
are frequently flaked in recent runs like HBASE-15152.

Given the status, I believe the patch here is safe.

> Resolve IS2_INCONSISTENT_SYNC findbugs warnings in 
> AuthenticationTokenSecretManager
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-15148
>                 URL: https://issues.apache.org/jira/browse/HBASE-15148
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-15148.patch, HBASE-15148.patch
>
>
> After efforts in HBASE-15118, we still see IS2_INCONSISTENT_SYNC warning in 
> AuthenticationTokenSecretManager in [HadoopQA report | 
> https://builds.apache.org/job/PreCommit-HBASE-Build/197/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html]
>  for HBASE-13960:
> {noformat}
> In class 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager
> Field 
> org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.lastKeyUpdate
> Synchronized 50% of the time
> Unsynchronized access at AuthenticationTokenSecretManager.java:[line 343]
> Synchronized access at AuthenticationTokenSecretManager.java:[line 278]
> {noformat}
> Checking the code, we could see {{synchronized (this)}} in line 343 is 
> synchronizing on the instance of the subclass 
> {{AuthenticationTokenSecretManager$LeaderElector}} while {{lastKeyUpdate}} is 
> a variable of the parent class instance
> Will fix the issue in this JIRA



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to