[
https://issues.apache.org/jira/browse/HBASE-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145682#comment-15145682
]
Francis Liu commented on HBASE-6721:
------------------------------------
Thanks for the list [~eclark]. Some comments.
> Yeah, address the groups naming thing.
Sounds good.
> moving in its own module seems easy since most of the code is already
> isolated, but there are few things that we never done, like having the shell
> commands in a module different than hbase-shell
The previous agreement was to keep the gorup commands in hbase-shell the same
as security before. Would guys still be ok with this? [~eclark] [~mbertozzi]
> Address the ServerName questions, breaking compat is not an option.
I think you misread the change. The code change was to actually fix a broken
unit test as it was using colon as a delimiter to serverName. I just fixed it
by changing the colon to ','. If this is not the case please feel free to point
it out in RB so I can address it properly.
> Don't go around the Metrics to get to jmx
The reason I went around metrics was because the information being published is
not really what is consumed as metrics, it's basically just group information
(name, tables, servers, etc) . It'd be ugly but probably possible to shoehorn
this into the metrics subsystem. Is this really how we do this even for
non-metrics related information to be published? There's alot less flexibility
in how we can structure the metadata.
> Don't create a new protobuf class when not needed
This was actually a review comment made by [~jmhsieh]. I'll take a look if
ServerName can suffice as a substitute.
> Move it into a different module with a profile that doesn't include it.
Will do.
> If/when those are addressed then I would remove my -1. I would be a -0.9 but
> I wouldn't block it.
Thanks.
> RegionServer Group based Assignment
> -----------------------------------
>
> Key: HBASE-6721
> URL: https://issues.apache.org/jira/browse/HBASE-6721
> Project: HBase
> Issue Type: New Feature
> Reporter: Francis Liu
> Assignee: Francis Liu
> Labels: hbase-6721
> Attachments: 6721-master-webUI.patch, HBASE-6721
> GroupBasedLoadBalancer Sequence Diagram.xml, HBASE-6721-DesigDoc.pdf,
> HBASE-6721-DesigDoc.pdf, HBASE-6721-DesigDoc.pdf, HBASE-6721-DesigDoc.pdf,
> HBASE-6721_0.98_2.patch, HBASE-6721_10.patch, HBASE-6721_11.patch,
> HBASE-6721_12.patch, HBASE-6721_13.patch, HBASE-6721_14.patch,
> HBASE-6721_15.patch, HBASE-6721_8.patch, HBASE-6721_9.patch,
> HBASE-6721_9.patch, HBASE-6721_94.patch, HBASE-6721_94.patch,
> HBASE-6721_94_2.patch, HBASE-6721_94_3.patch, HBASE-6721_94_3.patch,
> HBASE-6721_94_4.patch, HBASE-6721_94_5.patch, HBASE-6721_94_6.patch,
> HBASE-6721_94_7.patch, HBASE-6721_98_1.patch, HBASE-6721_98_2.patch,
> HBASE-6721_hbase-6721_addendum.patch, HBASE-6721_trunk.patch,
> HBASE-6721_trunk.patch, HBASE-6721_trunk.patch, HBASE-6721_trunk1.patch,
> HBASE-6721_trunk2.patch, balanceCluster Sequence Diagram.svg,
> hbase-6721-v15-branch-1.1.patch, hbase-6721-v16.patch, hbase-6721-v17.patch,
> hbase-6721-v18.patch, hbase-6721-v19.patch, hbase-6721-v20.patch,
> hbase-6721-v21.patch, hbase-6721-v22.patch, hbase-6721-v23.patch,
> hbase-6721-v25.patch, immediateAssignments Sequence Diagram.svg,
> randomAssignment Sequence Diagram.svg, retainAssignment Sequence Diagram.svg,
> roundRobinAssignment Sequence Diagram.svg
>
>
> In multi-tenant deployments of HBase, it is likely that a RegionServer will
> be serving out regions from a number of different tables owned by various
> client applications. Being able to group a subset of running RegionServers
> and assign specific tables to it, provides a client application a level of
> isolation and resource allocation.
> The proposal essentially is to have an AssignmentManager which is aware of
> RegionServer groups and assigns tables to region servers based on groupings.
> Load balancing will occur on a per group basis as well.
> This is essentially a simplification of the approach taken in HBASE-4120. See
> attached document.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
