[
https://issues.apache.org/jira/browse/HBASE-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147665#comment-15147665
]
Preston Koprivica commented on HBASE-15243:
-------------------------------------------
I think the risk here is that the underlying assumption is wrong.
For MUST_PASS_ALL filter lists:
{quote}
If any filter in the filter list returns a SEEK_NEXT_USING_HINT return code,
then no other row/cell prior the hinted row will be accepted.
{quote}
The implication here, and it's definitely reflected in your change, is that any
other return code can essentially be ignored. So far, I've assumed that's
correct, but I'm not an expert in hbase filters. Any concerns with that
assumption? For some reason, I can't apply the latest patch. Getting "fatal:
corrupt patch at line 69". I'll continue to review what I can in the meantime.
{quote}
This is at least an incompatible change, right ?
{quote}
I'll leave it to you to make the final call, but I'm not sure if I'd classify
this as incompatible. The fact that a test has to be changed is probably
indicative of testing against the concrete implementation, as opposed to
testing against higher level functionality.
> Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList
> return SEEK_NEXT_USING_HINT
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-15243
> URL: https://issues.apache.org/jira/browse/HBASE-15243
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-15243-v1.txt
>
>
> As Preston Koprivica pointed out at the tail of HBASE-4394, when all filters
> in a MUST_PASS_ONE FilterList return a SEEK_USING_NEXT_HINT code, we should
> return SEEK_NEXT_USING_HINT from the FilterList to utilize the lowest seek
> value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
