[
https://issues.apache.org/jira/browse/HBASE-15400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182069#comment-15182069
]
Hadoop QA commented on HBASE-15400:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
36s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 44s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 32s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
26s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
51s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 42s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 26s
{color} | {color:red} Patch generated 3 new checkstyle issues in hbase-server
(total was 86, now 87). {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 29 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
23m 42s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 3s
{color} | {color:red} hbase-server introduced 7 new FindBugs issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 19s {color}
| {color:red} hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 36m 17s {color}
| {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 101m 43s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Read of unwritten public or protected field boundary2Writer in new
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter(List) At
DateTieredMultiFileWriter.java:protected field boundary2Writer in new
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter(List) At
DateTieredMultiFileWriter.java:[line 45] |
| | Read of unwritten public or protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.append(Cell) At
DateTieredMultiFileWriter.java:protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.append(Cell) At
DateTieredMultiFileWriter.java:[line 51] |
| | Read of unwritten public or protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.boundaryAndWriters()
At DateTieredMultiFileWriter.java:protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.boundaryAndWriters()
At DateTieredMultiFileWriter.java:[line 66] |
| | Read of unwritten public or protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.writers() At
DateTieredMultiFileWriter.java:protected field boundary2Writer in
org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.writers() At
DateTieredMultiFileWriter.java:[line 71] |
| | Unwritten public or protected
field:org.apache.hadoop.hbase.regionserver.DateTieredMultiFileWriter.boundary2Writer
At DateTieredMultiFileWriter.java:[line 45] |
| | Write to static field
org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactionRequest.boundaries
from instance method new
org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactionRequest(Collection,
List) At DateTieredCompactionRequest.java:from instance method new
org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactionRequest(Collection,
List) At DateTieredCompactionRequest.java:[line 30] |
| | Dead store to readersToClose in
org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactor.compact(CompactionRequest,
List, ThroughputController, User) At
DateTieredCompactor.java:org.apache.hadoop.hbase.regionserver.compactions.DateTieredCompactor.compact(CompactionRequest,
List, ThroughputController, User) At DateTieredCompactor.java:[line 84] |
| JDK v1.8.0 Failed junit tests |
hadoop.hbase.regionserver.TestStripeStoreFileManager |
| JDK v1.8.0 Timed out junit tests |
org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy |
| | org.apache.hadoop.hbase.regionserver.TestHeapMemoryManager |
| | org.apache.hadoop.hbase.regionserver.TestStripeCompactor |
| | org.apache.hadoop.hbase.security.TestSecureIPC |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler |
| | org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | org.apache.hadoop.hbase.regionserver.TestSplitTransaction |
| JDK v1.7.0_79 Failed junit tests |
hadoop.hbase.regionserver.TestStripeStoreFileManager |
| | hadoop.hbase.regionserver.TestStripeCompactor |
| JDK v1.7.0_79 Timed out junit tests |
org.apache.hadoop.hbase.regionserver.compactions.TestStripeCompactionPolicy |
| | org.apache.hadoop.hbase.security.TestSecureIPC |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler |
| | org.apache.hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | org.apache.hadoop.hbase.regionserver.TestSplitTransaction |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12791657/HBASE-15400.patch |
| JIRA Issue | HBASE-15400 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / ef712df |
| findbugs | v3.0.0 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/new-findbugs-hbase-server.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/858/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt
|
| JDK v1.7.0_79 Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/testReport/ |
| modules | C: hbase-server U: hbase-server |
| Max memory used | 207MB |
| Powered by | Apache Yetus 0.1.0 http://yetus.apache.org |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/858/console |
This message was automatically generated.
> Using Multiple Output for Date Tiered Compaction
> ------------------------------------------------
>
> Key: HBASE-15400
> URL: https://issues.apache.org/jira/browse/HBASE-15400
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction
> Reporter: Clara Xiong
> Assignee: Clara Xiong
> Fix For: 2.0.0
>
> Attachments: HBASE-15400.patch
>
>
> When we compact, we can output multiple files along the current window
> boundaries. There are two use cases:
> 1. Major compaction: We want to output date tiered store files.
> 2. Bulk load files and the old file generated by major compaction before
> upgrading to DTCP.
> Pros:
> 1. Restore locality, process versioning, updates and deletes while
> maintaining the tiered layout.
> 2. The best way to fix a skewed layout.
>
> This work is based on a prototype of date tiered file writer from
> HBASE-15389. I have to call out a few design decisions:
> 1. We only want to output the files along all windows for major compaction.
> And we want to output multiple files older than max age in the sizes of the
> maximum tier window size determined by base window size, windows per tier and
> max age.
> 2. For minor compaction, we don't want to output too many files, which will
> remain around because of current restriction of contiguous compaction by seq
> id. I will only output two files if all the files in the windows are being
> combined, one for the data within window and the other for the out-of-window
> tail. If there is any file in the window excluded from compaction, only one
> file will be output from compaction. When the windows are promoted, the
> situation of out of order data will gradually improve.
> 3. We have to pass the boundaries with the list of store file as a complete
> time snapshot instead of two separate calls because window layout is
> determined by the time the computation is called. So we will need new type of
> compaction request.
> 4. Since we will assign the same seq id for all output files, we need to sort
> by maxTimestamp subsequently. Right now all compaction policy gets the files
> sorted for StoreFileManager which sorts by seq id and other criteria. I will
> use this order for DTCP only, to avoid impacting other compaction policies.
> 5. We need some cleanup of current design of StoreEngine and CompactionPolicy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
