[ 
https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183264#comment-15183264
 ] 

Ted Yu commented on HBASE-15406:
--------------------------------

bq. when one presses ctrl-c in terminal, that should be interruptible signal

I wouldn't depend on the signal handler for cleaning up the switch. As 
mentioned earlier, network partition may render the cleanup ineffective.

If we introduce ephemeral znode, do we still keep the current switch znode ?
If so, changing the switch from hbck would involve adjusting value of current 
znode and adding ephemeral znode at the same time. The values stored in current 
znode would need to expand beyond true / false because we want to distinguish 
the scenario where hbck (or some other tool) turns off split / merge for the 
duration of the operation.

What do you think, [~mantonov] ?

> Split / merge switch left disabled after early termination of hbck
> ------------------------------------------------------------------
>
>                 Key: HBASE-15406
>                 URL: https://issues.apache.org/jira/browse/HBASE-15406
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>
> This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday:
> Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster
> Terminate hbck early
> Enter hbase shell where I observed:
> {code}
> hbase(main):001:0> splitormerge_enabled 'SPLIT'
> false
> 0 row(s) in 0.3280 seconds
> hbase(main):002:0> splitormerge_enabled 'MERGE'
> false
> 0 row(s) in 0.0070 seconds
> {code}
> Expectation is that the split / merge switches should be restored to default 
> value after hbck exits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to