[ https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191364#comment-15191364 ]
Ted Yu commented on HBASE-15411: -------------------------------- In test run of TestFullBackup#testFullBackupSingle, even though snapshot succeeded: {code} 2016-03-10 20:33:13,000 DEBUG [B.defaultRpcServer.handler=1,queue=0,port=56481] snapshot.SnapshotManager(359): Snapshot '{ ss=snapshot_1457670792650_default_test-1457670784996 table=test-1457670784996 type=FLUSH }' has completed, notifying client. {code} there was no occurrence of the following log at the beginning of state 3 (test finished soon after taking snapshot): {code} case SNAPSHOT_COPY: // do snapshot copy LOG.debug("snapshot copy"); {code} Tried moving snapshot action into FullTableBackupProcedure - result was the same. > Rewrite backup with Procedure V2 > -------------------------------- > > Key: HBASE-15411 > URL: https://issues.apache.org/jira/browse/HBASE-15411 > Project: HBase > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Ted Yu > Attachments: 15411-v1.txt, 15411-v3.txt, 15411-v5.txt, 15411-v6.txt, > FullTableBackupProcedure.java > > > Currently full / incremental backup is driven by BackupHandler (see call() > method for flow). > This issue is to rewrite the flow using Procedure V2. > States (enum) for full / incremental backup would be introduced in > Backup.proto which correspond to the steps performed in BackupHandler#call(). > executeFromState() would pace the backup based on the current state. > serializeStateData() / deserializeStateData() would be used to persist state > into procedure WAL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)